1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/xpdev/link_list.c lin

    From Rob Swindell (on Debian L@VERT to Git commit to main/sbbs/m on Wed Jan 22 13:59:00 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/31c010080e7c0d643f8b1975
    Modified Files:
    src/xpdev/link_list.c link_list.h
    Log Message:
    Add/use new function: listAddNodeWithFlags()

    Fixes race condition/possible crash in listAddNodeData(), listAddNodeString() and listAddNodeList(). These functions were modifying the node->flags *after*
    a node was added to the list and list lock released.

    This is most likely the cause of the issue caught by valgrind when running the jsexec-testsuite:
    https://gitlab.synchro.net/main/sbbs/-/jobs/498286

    Thank you Deuce and valgrind, nice catch!
  • From Rob Swindell (on Debian L@VERT to Git commit to main/sbbs/m on Wed Jan 22 14:34:00 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/a147f9ee54b391cf92d277d0
    Modified Files:
    src/xpdev/link_list.c link_list.h
    Log Message:
    Change 'long' to 'int' in link list API

    so the sizes of these elements are the same across all our current target platforms